Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to creating the DMG, we also sign the app and notarize the DMG.
To create the keys, this is what I did:
Then a Developer ID Application and Installer were created, which gave a
.cer
file. Converting that to a P12:Additionally, we need to create provisioning profile for Mac OS, using the certificate above.
Then upload the P12, password, etc, to the secrets. Reference: https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development (but note the different provisioning file name and the use of both certs, even though we actually only sign with the Application, not the Installer, one)
I wasn't able to get fastlane to manage these certs, which is annoying. The docs suggest that they support Developer ID types, but I couldn't figure it out.